Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(date-time input): Label in Material with read-only #1182

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix(date-time input): Label in Material with read-only #1182

merged 1 commit into from
Apr 25, 2024

Conversation

rkaraivanov
Copy link
Member

  • Additionally cleaned up some low-hanging code for easier reading.

Closes #1166

@rkaraivanov
fix(date-time input): Label in Material with read-only
713fdaa 
* Additionally cleaned up some low-hanging code
for easier reading.

Closes #1166
@rkaraivanov
Copy link
Member Author

rkaraivanov commented Apr 25, 2024 •
edited
Loading

@damyanpetev

I've bumped the ES lib version in the tsconfig since we should really target 2022 baseline for our supported browsers.
Check this and this.

@damyanpetev damyanpetev merged commit 07f7ef2 into master Apr 25, 2024
5 checks passed
@damyanpetev damyanpetev deleted the rkaraivanov/fix-1166 branch April 25, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damyanpetev damyanpetev damyanpetev approved these changes

Assignees

@ddaribo ddaribo

Labels
date-time-input ✅ status: verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IgcDateTimeInput: label is not positioned correctly when readOnly=true
3 participants
@rkaraivanov @damyanpetev @ddaribo