Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slider): update indigo slider #1221

Merged
merged 8 commits into from
May 31, 2024
Merged

Conversation

didimmova
Copy link
Contributor

Closes #1213

@sbayreva
Copy link

sbayreva commented May 29, 2024

  1. The space between the tick marks and the base track should be 4px
  2. Not sure whether this is a problem but when inspected the marking rectangular is not in the center of the thumb.
Screenshot 2024-05-29 at 14 23 00
  1. The space between tickmarks and labels should be 4px

@andiesm813 Please, confirm and add if there is anything else.

@sbayreva
Copy link

  1. The space between the tick marks and the base track should be 4px
  2. Not sure whether this is a problem but when inspected the marking rectangular is not in the center of the thumb.
Screenshot 2024-05-29 at 14 23 00 3. The space between tickmarks and labels should be 4px

@andiesm813 Please, confirm and add if there is anything else.

Verified by my side, waiting for @andiesm813 approval.

@andiesm813
Copy link

All looks good to me! ✅

@simeonoff simeonoff merged commit 6d1c3bc into master May 31, 2024
5 checks passed
@simeonoff simeonoff deleted the didimmova/indigo-slider branch May 31, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider: Theme Issues
5 participants