Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(icon-button): update component styles #1228

Merged
merged 14 commits into from
Jun 12, 2024

Conversation

SisIvanova
Copy link
Contributor

Closes #1165

Theming Package for testing - IgniteUI/igniteui-theming/pull/274

@sbayreva
Copy link

sbayreva commented Jun 4, 2024

Fluent

  1. (Light Mode ) Flat , active state icon button - when inspected the foreground says it is Primary 800 but actually there is no visible change of the foreground itself. (Tested with Figma color picker)
Screenshot 2024-06-04 at 14 42 21
  1. (Dark Mode ) Flat , active state icon button - when inspected the foreground says it is Primary 100 but actually there is no visible change of the foreground itself. (Tested with Figma color picker)

  2. (Light Mode ) Flat button is on hover - there is no visible change for the foreground, even though when the element is inspected it says that the foreground is primary 600. (Tested with Figma color picker)

  3. (Dark Mode ) Flat button is on hover - there is no visible change for the foreground, even though when the element is inspected it says that the foreground is primary 200. (Tested with Figma color picker)

desig9stein
desig9stein previously approved these changes Jun 5, 2024
@sbayreva
Copy link

sbayreva commented Jun 5, 2024

Indigo

  1. (Dark Mode) Contained icon button- the focus border should be primary 400 with 50% opacity not white with 20% opacity as it is now
Screenshot 2024-06-05 at 10 33 23
  1. (Light Mode) Outlined icon button- On Hover and Active states the color of the border should be grays. 600. There is a visual change but when inspected it says grays. 500
Screenshot 2024-06-05 at 14 16 29

@andiesm813
Copy link

Indigo icon buttons looked good to me in light and dark modes. ✅✅

@imincheva

This comment was marked as resolved.

@sbayreva
Copy link

sbayreva commented Jun 10, 2024

Fluent

  1. (Light Mode ) Flat , active state icon button - when inspected the foreground says it is Primary 800 but actually there is no visible change of the foreground itself. (Tested with Figma color picker)
Screenshot 2024-06-04 at 14 42 21 2. (Dark Mode ) Flat , active state icon button - when inspected the foreground says it is Primary 100 but actually there is no visible change of the foreground itself. (Tested with Figma color picker) 3. (Light Mode ) Flat button is on hover - there is no visible change for the foreground, even though when the element is inspected it says that the foreground is primary 600. (Tested with Figma color picker) 4. (Dark Mode ) Flat button is on hover - there is no visible change for the foreground, even though when the element is inspected it says that the foreground is primary 200. (Tested with Figma color picker)

All applied and verified!

@sbayreva
Copy link

Indigo

  1. (Dark Mode) Contained icon button- the focus border should be primary 400 with 50% opacity not white with 20% opacity as it is now
Screenshot 2024-06-05 at 10 33 23 2. (Light Mode) Outlined icon button- On Hover and Active states the color of the border should be grays. 600. There is a visual change but when inspected it says grays. 500 Screenshot 2024-06-05 at 14 16 29

All applied and verified!

desig9stein
desig9stein previously approved these changes Jun 12, 2024
@simeonoff simeonoff merged commit f3af105 into master Jun 12, 2024
5 checks passed
@simeonoff simeonoff deleted the sivanova/icon-btn-refinement branch June 12, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon Button refinement
7 participants