refactor(themes): update for bootstrap defaults #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simeonoff
changed the title
simeonoff
changed the title
…niteui-webcomponents into simeonoff/bootstrap-defaults
DiyanDimitrov
requested review from
DiyanDimitrov
and removed request for
gedinakova
SisIvanova
approved these changes
Nov 16, 2021
DiyanDimitrov
suggested changes
Nov 16, 2021
| @@ -41,6 +41,7 @@ export default class IgcIconButtonComponent extends IgcButtonBaseComponent { | |||
| name=${ifDefined(this.name)} | |||
| collection=${ifDefined(this.collection)} | |||
| .mirrored=${this.mirrored} | |||
| variant=${this.variant} | |||
There was a problem hiding this comment.
igc-icon doesn't have variant attribute.
| @@ -29,9 +29,12 @@ const Template: Story<any, Context> = ( | |||
| ) => { | |||
| return html` | |||
| <igc-navbar dir=${ifDefined(direction)} style="height:30px"> | |||
| <igc-icon slot="start" name="home"></igc-icon> | |||
There was a problem hiding this comment.
Home icon is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.