Rating component #139
Merged
Rating component #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onents into rkaraivanov/rating
…onents into rkaraivanov/rating
Added attributes needed for ARIA and standard form handling Component is following new export package structure
* Selecting the same value will reset the rating * Rated/unrated symbols accept a callback function that can resolve the symbol for the appropriate position * Added event on hover which returns the current "active" index
…onents into rkaraivanov/rating
gedinakova
previously requested changes
Dec 23, 2021
DiyanDimitrov
suggested changes
Jan 5, 2022
There was a problem hiding this comment.
We may consider adding a property to highlight only the selected item similar to this, but it is not necessarily a v1 feature.
…teui-webcomponents into rkaraivanov/rating
…onents into rkaraivanov/rating � Conflicts: � src/index.ts � src/styles/themes/light/bootstrap.scss � src/styles/themes/light/fluent.scss � src/styles/themes/light/indigo.scss
DiyanDimitrov
previously approved these changes
Mar 14, 2022
DiyanDimitrov
previously approved these changes
Mar 14, 2022
- fix fluent styles after the last refactor
…teui-webcomponents into rkaraivanov/rating
…teui-webcomponents into rkaraivanov/rating
DiyanDimitrov
approved these changes
Mar 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4 #189