Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(checkbox): implement-dark-themes #158

Merged
merged 4 commits into from
Dec 1, 2021

Conversation

SisIvanova
Copy link
Contributor

@SisIvanova SisIvanova commented Nov 29, 2021

Closes #149

@SisIvanova SisIvanova linked an issue Nov 29, 2021 that may be closed by this pull request
5 tasks
Copy link
Collaborator

@simeonoff simeonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't copy the entire source code for each light theme. Rather include the light mixin and modify just the parts that need modifying.

@@ -1,34 +1,20 @@
@use '../../styles/utilities' as utils;
@use 'checkbox.fluent.scss' as light-checkbox;

@include light-checkbox.theme();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should rather be included in the theme mixin.

@simeonoff simeonoff merged commit 636db17 into simeonoff/dark-themes Dec 1, 2021
@simeonoff simeonoff deleted the sivanova/dark-checkbox branch December 1, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Checkbox Dark Themes
2 participants