Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add slider component #77

Merged
merged 87 commits into from
Jan 17, 2022
Merged

Add slider component #77

merged 87 commits into from
Jan 17, 2022

Conversation

mtsvyatkova
Copy link
Contributor

Closes #39

@rkaraivanov
Copy link
Member

rkaraivanov commented Oct 14, 2021

@mtsvyatkova
Ok, can we take a different approach for the slider component.

Can we:

  • Separate the thumb logic and implementation as a separate component
  • Make use of the @watch decorator we have in the repository instead of calling requestUpdate. As
    a bonus it can wait for the first update paint.
  • The implementation is very "Angularish" which is maybe not the correct approach in this case.

Maybe we can get together in a session and discuss the points above

Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above ☝️

@DiyanDimitrov
Copy link
Contributor

@gmurray81, Could you please take a look at the public API of the slider components and let us know if it will work ok for Blazor? I have some concerns for the range slider. We have lower and upper value properties and a single igcInput/igcChange event is emitted when any of the two values is changed. Is that going to work ok for the Blazor bindings?

@gmurray81
Copy link
Member

Thanks for the heads up @DiyanDimitrov will look into it soon.

@DiyanDimitrov
Copy link
Contributor

Thanks for the heads up @DiyanDimitrov will look into it soon.

@gmurray81, Did you get a chance to look into this?

@gmurray81
Copy link
Member

@DiyanDimitrov I think we should be able to make that work as long as the args have the values in them

@gmurray81
Copy link
Member

but I'll probably need to adjust something in the auto gen, at a guess

@rkaraivanov rkaraivanov merged commit 75de38c into master Jan 17, 2022
@rkaraivanov rkaraivanov deleted the mtsvyatkova/slider branch January 17, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slider component
7 participants