Commit 4f79ba4: Build Errors Affect Usage? #74

githububub · 2016-12-17T00:53:19Z

udevil.c: In function ‘restore_privileges’:
udevil.c:625:5: warning: ignoring return value of ‘seteuid’, declared with attribute warn_unused_result [-Wunused-result]
seteuid( 0 );
^~~~~~~~~~~~
udevil.c:626:5: warning: ignoring return value of ‘setegid’, declared with attribute warn_unused_result [-Wunused-result]
setegid( orig_egid );
^~~~~~~~~~~~~~~~~~~~
udevil.c: In function ‘create_auto_media’:
udevil.c:2358:5: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result [-Wunused-result]
chown( AUTO_MEDIA_DIR, 0, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2360:5: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result [-Wunused-result]
chown( auto_media, 0, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2387:9: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result [-Wunused-result]
chown( auto_media, orig_ruid, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function ‘umount_path’:
udevil.c:2148:5: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2149:5: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2170:5: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2171:5: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function ‘mount_knows’:
udevil.c:2298:5: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2299:5: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2312:5: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2313:5: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function ‘mount_device’:
udevil.c:2219:9: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2220:9: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2245:9: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2246:9: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function ‘exec_program’:
udevil.c:2016:9: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2017:9: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2035:9: warning: ignoring return value of ‘setreuid’, declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2036:9: warning: ignoring return value of ‘setregid’, declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~

mati75 · 2016-12-17T10:59:45Z

You can ignore it.

OmegaPhil · 2017-03-25T16:20:25Z

I've just been pinged about this (not actually a maintainer currently) - for reference I don't get any warnings compiling udevil, even with CFLAGS='-Wunused-result'.

OmegaPhil · 2017-03-25T18:15:54Z

Forgot to mention the obvious: gcc (Debian 6.3.0-10) 6.3.0 20170321

githububub · 2017-03-26T17:27:19Z

Commit d73166c. Errors persist. gcc (Arch 6.3.1-2) 6.3.1. Full build log:

==> Starting build()...
checking for a BSD-compatible install... /usr/bin/install -c
checking whether build environment is sane... yes
checking for a thread-safe mkdir -p... ./install-sh -c -d
checking for gawk... no
checking for mawk... no
checking for nawk... no
checking for awk... awk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether NLS is requested... no
checking for style of include used by make... GNU
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether gcc understands -c and -o together... yes
checking dependency style of gcc... none
checking for intltool >= 0.21... 0.51.0 found
checking for intltool-update... /usr/bin/intltool-update
checking for intltool-merge... /usr/bin/intltool-merge
checking for intltool-extract... /usr/bin/intltool-extract
checking for xgettext... /usr/bin/xgettext
checking for msgmerge... /usr/bin/msgmerge
checking for msgfmt... /usr/bin/msgfmt
checking for gmsgfmt... /usr/bin/msgfmt
checking for perl... /usr/bin/perl
checking for perl >= 5.8.1... 5.24.1
checking for XML::Parser... ok
checking whether to enable maintainer-specific portions of Makefiles... no
checking for library containing strerror... none required
checking how to run the C preprocessor... gcc -E
checking for grep that handles long lines and -e... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for ANSI C header files... yes
checking build system type... x86_64-unknown-linux-gnu
checking host system type... x86_64-unknown-linux-gnu
checking how to print strings... print -r
checking for a sed that does not truncate output... /usr/bin/sed
checking for fgrep... /usr/bin/grep -F
checking for ld used by gcc... /usr/bin/ld
checking if the linker (/usr/bin/ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... /usr/bin/nm -B
checking the name lister (/usr/bin/nm -B) interface... BSD nm
checking whether ln -s works... yes
checking the maximum length of command line arguments... 1572864
checking whether the shell understands some XSI constructs... yes
checking whether the shell understands "+="... yes
checking how to convert x86_64-unknown-linux-gnu file names to x86_64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for /usr/bin/ld option to reload object files... -r
checking for objdump... objdump
checking how to recognize dependent libraries... pass_all
checking for dlltool... no
checking how to associate runtime and link libraries... print -r --
checking for ar... ar
checking for archiver @file support... @
checking for strip... strip
checking for ranlib... ranlib
checking command to parse /usr/bin/nm -B output from gcc object... ok
checking for sysroot... no
checking for mt... no
checking if : is a manifest tool... no
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if gcc supports -fno-rtti -fno-exceptions... no
checking for gcc option to produce PIC... -fPIC -DPIC
checking if gcc PIC flag -fPIC -DPIC works... yes
checking if gcc static flag -static works... yes
checking if gcc supports -c -o file.o... yes
checking if gcc supports -c -o file.o... (cached) yes
checking whether the gcc linker (/usr/bin/ld -m elf_x86_64) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking whether /usr/bin/ld -m elf_x86_64 accepts --as-needed... yes
checking whether /usr/bin/ld -m elf_x86_64 accepts -O1... yes
checking whether /usr/bin/ld -m elf_x86_64 accepts -Bsymbolic-functions... yes
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for GLIB... yes
checking for LIBUDEV... yes
checking locale.h usability... yes
checking locale.h presence... yes
checking for locale.h... yes
checking for LC_MESSAGES... yes
checking libintl.h usability... yes
checking libintl.h presence... yes
checking for libintl.h... yes
checking for ngettext in libc... yes
checking for dgettext in libc... yes
checking for bind_textdomain_codeset... yes
checking for msgfmt... (cached) /usr/bin/msgfmt
checking for dcgettext... yes
checking if msgfmt accepts -c... yes
checking for gmsgfmt... (cached) /usr/bin/msgfmt
checking for xgettext... (cached) /usr/bin/xgettext
checking for catalogs to be installed... ru
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating po/Makefile.in
config.status: creating man/Makefile
config.status: creating etc/Makefile
config.status: creating src/Makefile
config.status: creating config.h
config.status: executing depfiles commands
config.status: executing libtool commands
config.status: executing default-1 commands
config.status: executing po/stamp-it commands

udevil....................................... : Version 0.4.4+

Linux device support......................... : libudev
mount program................................ : /bin/mount
umount program............................... : /bin/umount
losetup program.............................. : /sbin/losetup
setfacl program.............................. : /usr/bin/setfacl
Install devmon systemd service files ?....... : no
Installation Prefix.......................... : /usr
The binary will be installed as /usr/bin/udevil
sysconfdir................................... : /etc
The configuration will be installed in /etc/udevil

Homepage: http://ignorantguru.github.io/udevil/

make all-recursive
make[1]: Entering directory '/tmp/archbuild/udevil/src/udevil'
Making all in etc
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil/etc'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil/etc'
Making all in po
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil/po'
file=echo de | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file de.po
file=echo es | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file es.po
file=echo fr | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file fr.po
file=echo it | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file it.po
file=echo pl | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file pl.po
file=echo pt_BR | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file pt_BR.po
file=echo ru | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file ru.po
file=echo sv | sed 's,.*/,,'.gmo
&& rm -f $file && /usr/bin/msgfmt -o $file sv.po
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil/po'
Making all in src
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil/src'
gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_LOCALE_DIR=""/usr/share/locale"" -DSYSCONFDIR=""/etc"" -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fmessage-length=0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror-implicit-function-declaration -march=amdfam10 -O2 -pipe -fno-plt -fstack-check -fstack-protector-all -fomit-frame-pointer -c -o udevil-udevil.o test -f 'udevil.c' || echo './'udevil.c
gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_LOCALE_DIR=""/usr/share/locale"" -DSYSCONFDIR=""/etc"" -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fmessage-length=0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror-implicit-function-declaration -march=amdfam10 -O2 -pipe -fno-plt -fstack-check -fstack-protector-all -fomit-frame-pointer -c -o udevil-device-info.o test -f 'device-info.c' || echo './'device-info.c
gcc -DHAVE_CONFIG_H -I. -I.. -DPACKAGE_LOCALE_DIR=""/usr/share/locale"" -DSYSCONFDIR=""/etc"" -D_FORTIFY_SOURCE=2 -fstrict-aliasing -fmessage-length=0 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_REENTRANT -D_FILE_OFFSET_BITS=64 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror-implicit-function-declaration -march=amdfam10 -O2 -pipe -fno-plt -fstack-check -fstack-protector-all -fomit-frame-pointer -c -o udevil-canonicalize.o test -f 'canonicalize.c' || echo './'canonicalize.c
udevil.c: In function 'restore_privileges':
udevil.c:625:5: warning: ignoring return value of 'seteuid', declared with attribute warn_unused_result [-Wunused-result]
seteuid( 0 );
^~~~~~~~~~~~
udevil.c:626:5: warning: ignoring return value of 'setegid', declared with attribute warn_unused_result [-Wunused-result]
setegid( orig_egid );
^~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'create_auto_media':
udevil.c:2358:5: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
chown( AUTO_MEDIA_DIR, 0, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2360:5: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
chown( auto_media, 0, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2387:9: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
chown( auto_media, orig_ruid, 0 );
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'umount_path':
udevil.c:2148:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2149:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2170:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2171:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'mount_knows':
udevil.c:2298:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2299:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2312:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2313:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'mount_device':
udevil.c:2219:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2220:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2245:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2246:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'exec_program':
udevil.c:2016:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( 0, -1 ); // mount needs real uid
^~~~~~~~~~~~~~~~~
udevil.c:2017:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( 0, -1 );
^~~~~~~~~~~~~~~~~
udevil.c:2035:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
setreuid( orig_ruid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2036:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
setregid( orig_rgid, -1 );
^~~~~~~~~~~~~~~~~~~~~~~~~
/bin/sh ../libtool --tag=CC --mode=link gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror-implicit-function-declaration -march=amdfam10 -O2 -pipe -fno-plt -fstack-check -fstack-protector-all -fomit-frame-pointer -Wl,-z,now -Wl,-O1,--sort-common,--as-needed,-z,relro -Wl,--as-needed -Wl,-O1 -Wl,-Bsymbolic-functions -o udevil udevil-udevil.o udevil-device-info.o udevil-canonicalize.o -lglib-2.0 -ludev
libtool: link: gcc -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -Werror-implicit-function-declaration -march=amdfam10 -O2 -pipe -fno-plt -fstack-check -fstack-protector-all -fomit-frame-pointer -Wl,-z -Wl,now -Wl,-O1 -Wl,--sort-common -Wl,--as-needed -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-O1 -Wl,-Bsymbolic-functions -o udevil udevil-udevil.o udevil-device-info.o udevil-canonicalize.o -lglib-2.0 -ludev
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil/src'
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil'
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil'
make[1]: Leaving directory '/tmp/archbuild/udevil/src/udevil'
==> Entering fakeroot environment...
==> Starting package()...
Making install in etc
make[1]: Entering directory '/tmp/archbuild/udevil/src/udevil/etc'
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil/etc'
make[2]: Nothing to be done for 'install-exec-am'.
make install-data-hook
make[3]: Entering directory '/tmp/archbuild/udevil/src/udevil/etc'
test -d /tmp/archbuild/udevil/pkg/udevil//etc/udevil || mkdir -p --
/tmp/archbuild/udevil/pkg/udevil//etc/udevil
test -f /tmp/archbuild/udevil/pkg/udevil//etc/udevil/udevil.conf || /usr/bin/install -c -m 644
./udevil.conf
/tmp/archbuild/udevil/pkg/udevil//etc/udevil/udevil.conf
make[3]: Leaving directory '/tmp/archbuild/udevil/src/udevil/etc'
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil/etc'
make[1]: Leaving directory '/tmp/archbuild/udevil/src/udevil/etc'
Making install in po
make[1]: Entering directory '/tmp/archbuild/udevil/src/udevil/po'
linguas="de es fr it pl pt_BR ru sv ";
for lang in $linguas; do
dir=/tmp/archbuild/udevil/pkg/udevil/usr/share/locale/$lang/LC_MESSAGES;
/bin/sh /tmp/archbuild/udevil/src/udevil/install-sh -d $dir;
if test -r $lang.gmo; then
/usr/bin/install -c -m 644 $lang.gmo $dir/udevil.mo;
echo "installing $lang.gmo as $dir/udevil.mo";
else
/usr/bin/install -c -m 644 ./$lang.gmo $dir/udevil.mo;
echo "installing ./$lang.gmo as"
"$dir/udevil.mo";
fi;
if test -r $lang.gmo.m; then
/usr/bin/install -c -m 644 $lang.gmo.m $dir/udevil.mo.m;
echo "installing $lang.gmo.m as $dir/udevil.mo.m";
else
if test -r ./$lang.gmo.m ; then
/usr/bin/install -c -m 644 ./$lang.gmo.m
$dir/udevil.mo.m;
echo "installing ./$lang.gmo.m as"
"$dir/udevil.mo.m";
else
true;
fi;
fi;
done
installing de.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/de/LC_MESSAGES/udevil.mo
installing es.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/es/LC_MESSAGES/udevil.mo
installing fr.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/fr/LC_MESSAGES/udevil.mo
installing it.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/it/LC_MESSAGES/udevil.mo
installing pl.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/pl/LC_MESSAGES/udevil.mo
installing pt_BR.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/pt_BR/LC_MESSAGES/udevil.mo
installing ru.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/ru/LC_MESSAGES/udevil.mo
installing sv.gmo as /tmp/archbuild/udevil/pkg/udevil/usr/share/locale/sv/LC_MESSAGES/udevil.mo
make[1]: Leaving directory '/tmp/archbuild/udevil/src/udevil/po'
Making install in src
make[1]: Entering directory '/tmp/archbuild/udevil/src/udevil/src'
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil/src'
make install-data-hook
.././install-sh -c -d '/tmp/archbuild/udevil/pkg/udevil/usr/bin'
make[3]: Entering directory '/tmp/archbuild/udevil/src/udevil/src'
test -z /tmp/archbuild/udevil/pkg/udevil//usr/bin || mkdir -p -- /tmp/archbuild/udevil/pkg/udevil//usr/bin
/usr/bin/install -c -m 644 -o root -g root -m 4755 -D ../src/udevil /tmp/archbuild/udevil//tmp/archbuild/udevil $ loc udevil
pkg/udevil//usr/bin/udevil
make[3]: Leaving directory '/tmp/archbuild/udevil/src/udevil/src'
/usr/bin/install -c devmon '/tmp/archbuild/udevil/pkg/udevil/usr/bin'
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil/src'
make[1]: Leaving directory '/tmp/archbuild/udevil/src/udevil/src'
make[1]: Entering directory '/tmp/archbuild/udevil/src/udevil'
make[2]: Entering directory '/tmp/archbuild/udevil/src/udevil'
make[2]: Nothing to be done for 'install-exec-am'.
make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/tmp/archbuild/udevil/src/udevil'
make[1]: Leaving directory '/tmp/archbuild/udevil/src/udevil'
==> Tidying install...
-> Removing doc files...
-> Removing empty directories...
-> Removing libtool files...
-> Removing static library files...
-> Stripping unneeded symbols from binaries and libraries...
-> Compressing man and info pages...
==> Checking for packaging issue...
==> Creating package "udevil"...
-> Generating .PKGINFO file...
-> Generating .BUILDINFO file...
-> Generating .MTREE file...
-> Compressing package...
100 % 55.6 KiB / 190.0 KiB = 0.293
==> Leaving fakeroot environment.
==> Finished making: udevil 0.4.4+r7+gd73166c-1 (Sun Mar 26 17:19:50 UTC 2017)

OmegaPhil · 2017-03-27T16:45:22Z

OK, so perhaps it will start failing in the same way when Devuan gets the next gcc. I'll add a task to check.

OmegaPhil · 2017-06-28T16:20:18Z

Even testing this with gcc-7 is producing no errors, presumably this is the correct way to do it:

CFLAGS='-Wunused-result' CC=gcc-7 ../configure
make -j 8

So I'm going to leave this ticket alone until someone with a better understanding emerges.

IgnorantGuru · 2017-07-05T21:51:14Z

Compilers do differ on this, but those are valid warnings as those functions' return values are probably ignored. Those warnings do not affect the function of the build, and the values were ignored deliberately as non-critical (usually if those were going to fail, earlier tests will fail, so error traps are practically useless at that point). They are so commonly non-critical that I think some compilers ignore them, or are setup to do so.

Usually the cleanest way to clear these is to just assign the return values to shut the compiler up.

Probably a quick review of the nearby code would be a good idea too, to see why those return values were treated that way, but that's usually the case.

OmegaPhil · 2017-07-06T11:50:51Z

Yes, but in this case the compiler has been explicitly configured to warn on unused values, and it isn't.

Looking at the first example given, udevil definitely is ignoring the return value of seteuid, so gcc is failing to pay attention to its configuration here (presumably something else is in play).

This is as far as I want to take it without being a maintainer.

On Debian this warning does not cause a build error across various versions, so this is not an issue for me.
For some reason gcc is ignoring explicit instructions to raise it as a warning.

If I was to become a maintainer, I'd fight the latter first, then go through udevil and try to do something sensible with the return values (likely overkill anyway).

ghost · 2018-02-08T23:03:06Z

Void linux here! (gcc 7.3.0)
Compiling the source code from the same commit 77a6180 as the Arch PKGBUILD, I can see the same kind of errors as @githububub during the build:

udevil.c: In function 'restore_privileges':
udevil.c:625:5: warning: ignoring return value of 'seteuid', declared with attribute warn_unused_result [-Wunused-result]
     seteuid( 0 );
     ^~~~~~~~~~~~
udevil.c:626:5: warning: ignoring return value of 'setegid', declared with attribute warn_unused_result [-Wunused-result]
     setegid( orig_egid );
     ^~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'create_auto_media':
udevil.c:2358:5: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
     chown( AUTO_MEDIA_DIR, 0, 0 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2360:5: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
     chown( auto_media, 0, 0 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2387:9: warning: ignoring return value of 'chown', declared with attribute warn_unused_result [-Wunused-result]
         chown( auto_media, orig_ruid, 0 );
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'umount_path':
udevil.c:2148:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
     setreuid( 0, -1 );  // mount needs real uid
     ^~~~~~~~~~~~~~~~~
udevil.c:2149:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
     setregid( 0, -1 );
     ^~~~~~~~~~~~~~~~~
udevil.c:2170:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
     setreuid( orig_ruid, -1 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2171:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
     setregid( orig_rgid, -1 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'mount_knows':
udevil.c:2298:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
     setreuid( 0, -1 );  // mount needs real uid
     ^~~~~~~~~~~~~~~~~
udevil.c:2299:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
     setregid( 0, -1 );
     ^~~~~~~~~~~~~~~~~
udevil.c:2312:5: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
     setreuid( orig_ruid, -1 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2313:5: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
     setregid( orig_rgid, -1 );
     ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'mount_device':
udevil.c:2219:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
         setreuid( 0, -1 );  // mount needs real uid
         ^~~~~~~~~~~~~~~~~
udevil.c:2220:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
         setregid( 0, -1 );
         ^~~~~~~~~~~~~~~~~
udevil.c:2245:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
         setreuid( orig_ruid, -1 );
         ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2246:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
         setregid( orig_rgid, -1 );
         ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c: In function 'exec_program':
udevil.c:2016:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
         setreuid( 0, -1 );  // mount needs real uid
         ^~~~~~~~~~~~~~~~~
udevil.c:2017:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
         setregid( 0, -1 );
         ^~~~~~~~~~~~~~~~~
udevil.c:2035:9: warning: ignoring return value of 'setreuid', declared with attribute warn_unused_result [-Wunused-result]
         setreuid( orig_ruid, -1 );
         ^~~~~~~~~~~~~~~~~~~~~~~~~
udevil.c:2036:9: warning: ignoring return value of 'setregid', declared with attribute warn_unused_result [-Wunused-result]
         setregid( orig_rgid, -1 );
         ^~~~~~~~~~~~~~~~~~~~~~~~~

OmegaPhil · 2018-02-09T10:12:18Z

These are not errors, they are warnings - they don't affect your ability to use or build the program.

ghost · 2018-02-09T10:16:38Z

ok, thank you @OmegaPhil

OmegaPhil · 2018-02-09T10:18:15Z

Specifically, see the maintainer's comment: #74 (comment)

OmegaPhil self-assigned this Jun 28, 2017

OmegaPhil added the need info label Jun 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Commit 4f79ba4: Build Errors Affect Usage? #74

Commit 4f79ba4: Build Errors Affect Usage? #74

githububub commented Dec 17, 2016

mati75 commented Dec 17, 2016

OmegaPhil commented Mar 25, 2017

OmegaPhil commented Mar 25, 2017

githububub commented Mar 26, 2017 •

edited

OmegaPhil commented Mar 27, 2017

OmegaPhil commented Jun 28, 2017

IgnorantGuru commented Jul 5, 2017

OmegaPhil commented Jul 6, 2017

ghost commented Feb 8, 2018

OmegaPhil commented Feb 9, 2018

ghost commented Feb 9, 2018

OmegaPhil commented Feb 9, 2018

Commit 4f79ba4: Build Errors Affect Usage? #74

Commit 4f79ba4: Build Errors Affect Usage? #74

Comments

githububub commented Dec 17, 2016

mati75 commented Dec 17, 2016

OmegaPhil commented Mar 25, 2017

OmegaPhil commented Mar 25, 2017

githububub commented Mar 26, 2017 • edited

OmegaPhil commented Mar 27, 2017

OmegaPhil commented Jun 28, 2017

IgnorantGuru commented Jul 5, 2017

OmegaPhil commented Jul 6, 2017

ghost commented Feb 8, 2018

OmegaPhil commented Feb 9, 2018

ghost commented Feb 9, 2018

OmegaPhil commented Feb 9, 2018

githububub commented Mar 26, 2017 •

edited