Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of component names #34

Merged
merged 2 commits into from
Mar 3, 2019
Merged

Conversation

Igorbek
Copy link
Owner

@Igorbek Igorbek commented Mar 3, 2019

As reported in #33, some identifiers like $ and _ are treated as component names and extend call on them is translated to use withConfig.
The issue is fixed by properly detecting component names as of following. Component name has to start with a capital character letter.

Additionally packages have been updated.

Fixes #33

@Igorbek Igorbek merged commit b113e31 into master Mar 3, 2019
@Igorbek Igorbek deleted the feature/extend-detection branch March 3, 2019 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

jQuery's extend method ($.extend) is treated as a styled component
1 participant