Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore componentIdPrefix fallback to getIdFromNode #518

Merged
merged 2 commits into from Mar 23, 2023
Merged

Restore componentIdPrefix fallback to getIdFromNode #518

merged 2 commits into from Mar 23, 2023

Conversation

roikoren755
Copy link
Contributor

image

As part of the changes for v2, componentIds lost their default sc prefix in the withConfig call.

@jaycetde
Copy link

jaycetde commented Feb 8, 2022

Is this something that can be looked into further? Without a componentIdPrefix set, I had -15w8dc5 generated as a componentId. It then tried to use that ID as a CSS selector - CSS class names cannot start with numbers, so the rule was not applied

Igorbek
Igorbek approved these changes Mar 23, 2023
View reviewed changes
Copy link
Owner

@Igorbek Igorbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@Igorbek Igorbek merged commit ffa4ad2 into Igorbek:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Igorbek Igorbek Igorbek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roikoren755 @jaycetde @Igorbek