Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL support #20

Closed
terinjokes opened this issue Oct 16, 2014 · 6 comments
Closed

URL support #20

terinjokes opened this issue Oct 16, 2014 · 6 comments

Comments

@terinjokes
Copy link

Continuing the discussion from #18 (comment)


It would be nice if Compass's URL functions were implemented, even if it comes down to variables we need to set before importing compass-mixins.

@Zauberfisch
Copy link

I think defining them in a .scss file is ok for the time being.
after all, if you want to configure them with compass, you would define them in the file config.rb, makes little difference to define them in a _config.scss here.

also, let me state here, the url function set is one of the most important features of compass to me, so I hope to see them in this repository soon ;)

@michaek
Copy link
Collaborator

michaek commented Oct 29, 2014

I'm still not sure this makes sense to port. If you want to prepend a variable, this is really simple:

$compass-image-path: 'your/image/path' !default;
@function image-url($path) {
  @return "#{$compass-image-path}/#{$path}";
}

I don't want to rule it out, but I'm not yet convinced.

@terinjokes
Copy link
Author

@michaek These mixins already use the url functions from Compass, without defining them, so they just appear unprocessed in the output.

@OnkelTem
Copy link

Hm... can't we just define lacking functions in js?

UPDATE. Sorry, I forgot that I'm not in node-sass' issue queue :)

@michaek
Copy link
Collaborator

michaek commented May 7, 2015

I agree it's strange to not support everything from Compass, but this is a library that seeks to go halfway, as it would be prohibitive to support all of Compass. I'd say its intention is to provide a crutch to get to the point where your project no longer depends on Compass.

@michaek michaek closed this as completed May 7, 2015
@gaomd
Copy link

gaomd commented Sep 6, 2015

@michaek The missing image-url() confused me, I believe I'm not alone, maybe we should note the incompleteness in the README.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants