Skip to content
This repository has been archived by the owner on Dec 2, 2021. It is now read-only.

Type declaration for optional parameters #5

Merged
merged 2 commits into from
Mar 31, 2018
Merged

Type declaration for optional parameters #5

merged 2 commits into from
Mar 31, 2018

Conversation

henrikh
Copy link
Contributor

@henrikh henrikh commented Mar 30, 2018

Optional parameters can be declared in the type using ?.

Optional parameters can be declared in the type using `?`.
@IjzerenHein
Copy link
Owner

Hi, the build is failing with this error, please fix before I can accept

src/constraint.ts(86,13): error TS1015: Parameter cannot have question mark and initializer.

@henrikh
Copy link
Contributor Author

henrikh commented Mar 31, 2018

Should work now.

@IjzerenHein IjzerenHein merged commit f9dd5a1 into IjzerenHein:master Mar 31, 2018
@IjzerenHein
Copy link
Owner

Awesome, thanks!

I've published a new release with this fix:
https://github.com/IjzerenHein/kiwi.js/releases/tag/v1.0.2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants