Fix "Invalid argument supplied for foreach()" in newVersionFound()

IlchCMS · Mar 10, 2020 · 4519d8e · 4519d8e
1 parent 68c3c74
commit 4519d8e
Showing 1 changed file with 13 additions and 7 deletions.
diff --git a/application/libraries/Ilch/Transfer.php b/application/libraries/Ilch/Transfer.php
@@ -255,18 +255,24 @@ public function setVersionNow($versionNow)
     }
 
     /**
-     * @return true/false
+     * Gets the versionslist and checks if there is a new version available.
+     *
+     * @return bool
      */
     public function newVersionFound()
     {
-        foreach ($this->getVersionsList() as $version => $requirements) {
-            if (version_compare(preg_replace('/\s+/', '', $version), $this->getVersionNow(), '>')) {
-                $this->setNewVersion(trim(preg_replace('/\s\s+/','', $version)));
-                $this->zipFile = $this->getZipSavePath().'Master-'.$this->getNewVersion().'.zip';
-                $this->checkRequirements($requirements);
-                return true;
+        $versionsList = $this->getVersionsList();
+        if ($versionsList !== null) {
+            foreach ($this->getVersionsList() as $version => $requirements) {
+                if (version_compare(preg_replace('/\s+/', '', $version), $this->getVersionNow(), '>')) {
+                    $this->setNewVersion(trim(preg_replace('/\s\s+/','', $version)));
+                    $this->zipFile = $this->getZipSavePath().'Master-'.$this->getNewVersion().'.zip';
+                    $this->checkRequirements($requirements);
+                    return true;
+                }
             }
         }
+
         return false;
     }