Alternative fix for the profilefields

Don't use the name as index as this leads to problems if the name contains for example spaces.
IlchCMS · May 14, 2017 · 731e623 · 731e623
1 parent 9b8743a
commit 731e623
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/application/modules/user/controllers/Panel.php b/application/modules/user/controllers/Panel.php
@@ -81,7 +81,8 @@ public function profileAction()
             ];
 
             foreach ($profileFields as $profileField) {
-                $post[$profileField->getName()] = trim($this->getRequest()->getPost($profileField->getName()));
+                $index = 'profileField'.$profileField->getId();
+                $post[$index] = trim($this->getRequest()->getPost($index));
             }
 
             $validation = Validation::create($post, [
@@ -111,10 +112,11 @@ public function profileAction()
                 $profilMapper->save($model);
 
                 foreach ($profileFields as $profileField) {
+                    $index = 'profileField'.$profileField->getId();
                     $profileFieldsContent = new ProfileFieldContentModel();
                     $profileFieldsContent->setFieldId($profileField->getId());
                     $profileFieldsContent->setUserId($this->getUser()->getId());
-                    $profileFieldsContent->setValue($post[$profileField->getName()]);
+                    $profileFieldsContent->setValue($post[$index]);
                     $profileFieldsContentMapper->save($profileFieldsContent);
                 }
 

diff --git a/application/modules/user/mappers/ProfileFields.php b/application/modules/user/mappers/ProfileFields.php
@@ -168,7 +168,7 @@ public function loadFromArray($profileFieldRow = [])
         }
 
         if (isset($profileFieldRow['name'])) {
-            $profileField->setName(str_replace(' ','-',$profileFieldRow['name']));
+            $profileField->setName($profileFieldRow['name']);
         }
 
         if (isset($profileFieldRow['type'])) {

diff --git a/application/modules/user/mappers/ProfileFieldsTranslation.php b/application/modules/user/mappers/ProfileFieldsTranslation.php
@@ -77,7 +77,7 @@ public function loadFromArray($profileFieldRow = [])
         }
 
         if (isset($profileFieldRow['name'])) {
-            $profileFieldTranslation->setName(str_replace(' ','-',$profileFieldRow['name']));
+            $profileFieldTranslation->setName($profileFieldRow['name']);
         }
 
         return $profileFieldTranslation;

diff --git a/application/modules/user/views/panel/profile.php b/application/modules/user/views/panel/profile.php
@@ -152,8 +152,9 @@ class="form-control"
 
                     if(!$profileField->getType()) :
                         $value = '';
-                        if ($this->originalInput($profileField->getName()) != '') {
-                            $value = $this->escape($this->originalInput($profileField->getName()));
+                        $index = 'profileField'.$profileField->getId();
+                        if ($this->originalInput($index) != '') {
+                            $value = $this->escape($this->originalInput($index));
                         } else {
                             foreach($profileFieldsContent as $profileFieldContent) {
                                 if($profileField->getId() == $profileFieldContent->getFieldId()) {
@@ -169,7 +170,7 @@ class="form-control"
                             <div class="col-lg-8">
                                <input type="text"
                                       class="form-control"
-                                      name="<?=$this->escape($profileField->getName()) ?>"
+                                      name="<?=$index ?>"
                                       placeholder="<?=$value ?>"
                                       value="<?=$value ?>" />
                             </div>