Merge af817f2 into c108169

weni-ai · Oct 25, 2018 · b2b43e3 · b2b43e3
2 parents c108169 + af817f2
commit b2b43e3
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 1 deletion.
diff --git a/bothub/api/v2/repository/serializers.py b/bothub/api/v2/repository/serializers.py
@@ -162,7 +162,7 @@ def get_intents(self, obj):
                 lambda intent: {
                     'value': intent,
                     'examples__count': obj.examples(
-                        exclude_deleted=False).filter(
+                        exclude_deleted=True).filter(
                             intent=intent).count(),
                 },
                 obj.intents),

diff --git a/bothub/api/v2/repository/tests.py b/bothub/api/v2/repository/tests.py
@@ -8,11 +8,13 @@
 from bothub.common.models import RepositoryCategory
 from bothub.common.models import Repository
 from bothub.common.models import RequestRepositoryAuthorization
+from bothub.common.models import RepositoryExample
 from bothub.common import languages
 
 from ..tests.utils import create_user_and_token
 
 from .views import RepositoryViewSet
+from .serializers import RepositorySerializer
 
 
 def get_valid_mockups(categories):
@@ -362,3 +364,36 @@ def test_false_when_request(self):
         available_request_authorization = content_data.get(
             'available_request_authorization')
         self.assertFalse(available_request_authorization)
+
+
+class IntentsInRepositorySerializer(TestCase):
+    def setUp(self):
+        self.owner, self.owner_token = create_user_and_token('owner')
+
+        self.repository = Repository.objects.create(
+            owner=self.owner,
+            name='Testing',
+            slug='test',
+            language=languages.LANGUAGE_EN)
+        RepositoryExample.objects.create(
+            repository_update=self.repository.current_update(),
+            text='hi',
+            intent='greet')
+
+    def test_count_1(self):
+        repository_data = RepositorySerializer(self.repository).data
+        intent = repository_data.get('intents')[0]
+        self.assertEqual(intent.get('examples__count'), 1)
+
+    def test_example_deleted(self):
+        example = RepositoryExample.objects.create(
+            repository_update=self.repository.current_update(),
+            text='hi',
+            intent='greet')
+        repository_data = RepositorySerializer(self.repository).data
+        intent = repository_data.get('intents')[0]
+        self.assertEqual(intent.get('examples__count'), 2)
+        example.delete()
+        repository_data = RepositorySerializer(self.repository).data
+        intent = repository_data.get('intents')[0]
+        self.assertEqual(intent.get('examples__count'), 1)