[WIP] ng15 support #97
Conversation
| @@ -378,7 +379,7 @@ export class MatTimepickerDirective | |||
| } | |||
| } | |||
|
|
|||
| @HostListener('keydown', ['$event']) keydownHandler(event: any) { | |||
| @HostListener('keydown', ['$event']) keydownHandler({ event }: { event: any; }): true | undefined { | |||
There was a problem hiding this comment.
| @HostListener('keydown', ['$event']) keydownHandler({ event }: { event: any; }): true | undefined { | |
| @HostListener('keydown', ['$event']) keydownHandler(event : KeyboardEvent): true | undefined { |
Angular does not wrap then $event in an object.
|
Oh nice, ng15 support ahead! 🥳 Any estimations, yet? |
|
Nice ng15🎉 is there an estimate of when it will be merged? |
|
@IliaIdakiev no pressure, but any estimations on this? My Angular15 migration is just waiting for this component. Since you already announced this in January, I hoped it would arrive pretty soon. Sure this is only community work, so really no pressure! But I start getting afraid this won't happen anytime soon / at all. |
|
@IliaIdakiev sorry for bumping, but any news on this? Its even time for ng16 now. Really don't mind if you just don't find the time but since I'd really need it, some news would be cool. If you're done with this lib, I could continue it. |
|
That push gave me a litte hope at least 😉 Any noticable plans on this project? |
|
Hey guys, the project is open source for a reason, there are a few small things not working on this PR so if you are in a hurry feel free to contribute. You can always run the PR see what's not working and resolve the issues. Cheers. |
|
Yeah, sure. The fact that you opened this PR just made me hope that you'll get this lib compatible with ng15 (or 16 now) yourself. This sure is way easier for an lib's author. If you could tell if you're at least planning to, it would be helpful in deciding wether to fix it myself, wait for an update or switch the lib. Open source or not, it would be nice to still moderate it (or deprecate if no longer needed). |
Status: