Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

Update regex for to accept course names with hyphens and underscores #134

Merged
merged 5 commits into from
Jun 15, 2020

Conversation

jgwerner
Copy link
Member

Accept course names with - and _.

Closes #133

Signed-off-by: Greg <werner.greg@gmail.com>
@jgwerner jgwerner added the fix Fixes a bug label Jun 13, 2020
@jgwerner jgwerner requested a review from netoisc June 13, 2020 23:02
@jgwerner jgwerner self-assigned this Jun 13, 2020
@codecov
Copy link

codecov bot commented Jun 13, 2020

Codecov Report

Merging #134 into master will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   71.78%   72.00%   +0.21%     
==========================================
  Files          13       13              
  Lines         918      918              
==========================================
+ Hits          659      661       +2     
+ Misses        259      257       -2     
Impacted Files Coverage Δ
src/illumidesk/authenticators/authenticator.py 91.61% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e9031f...d68ee5e. Read the comment docs.

Signed-off-by: Greg <werner.greg@gmail.com>
@jgwerner jgwerner requested a review from netoisc June 15, 2020 15:50
Copy link
Contributor

@netoisc netoisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgwerner jgwerner merged commit 1201130 into IllumiDesk:master Jun 15, 2020
@jgwerner jgwerner deleted the fix/update-course-id-regex branch June 15, 2020 15:54
@jgwerner jgwerner mentioned this pull request Jun 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Course names with hyphens lead to 400 errors when sending grades to the LMS
2 participants