[KK][GT] Cache temporary arrays in ChaControl.UpdateVisible #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch caches the 1D and 2D temporary arrays created in UpdateVisible. The transpiler is a little blunt, replacing all newarr instructions, so I included a check to ensure that we patch exactly 45 places. This should make it a little more robust against other plugins transpiling the same method.
ManlyMarco
reviewed
Aug 30, 2023
Good point, changed to use an array instead. (Let me know if you prefer squash + force-push rather than adding new commits) |
|
I'll most likely squash merge anyways so you can just push separate commits. |
ManlyMarco
approved these changes
Aug 30, 2023
ManlyMarco
added a commit
that referenced
this pull request
Sep 1, 2023
)" This reverts commit 3124e14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch caches the 1D and 2D temporary arrays created in UpdateVisible.
The transpiler is a little blunt, replacing all newarr instructions, so I included a check to ensure that we patch exactly 45 places. This should make it a little more robust against other plugins transpiling the same method.
I wrote some code (not included here) to check that all 45 arrays are indeed safe to cache.