[KK][GT] Cache temporary arrays in ChaControl.UpdateVisible #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is another attempt at 3124e14, which got reverted. Original commit message: > This patch caches the 1D and 2D temporary arrays created in > UpdateVisible. > > The transpiler is a little blunt, replacing all newarr instructions, > so I included a check to ensure that we patch exactly 45 places. > This should make it a little more robust against other plugins > transpiling the same method. The previous patch broke ClothesToAccessories when UpdateVisible contained an unexpected number of array allocations. This happened because the transpiler threw an exception, which, depending on the patch order, could prevent the transpiler defined by ClothesToAccessories (or any other plugin that patches the method) from running. This version avoids the issue by logging an error instead of throwing an exception. This version also removes the use of CodeMatcher.SetAndAdvance because it looks like it could destructively modify input code.
ManlyMarco
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another attempt at 3124e14, which got reverted.
The previous patch broke ClothesToAccessories when UpdateVisible contained an unexpected number of array allocations. This happened because the transpiler threw an exception, which, depending on the patch order, could prevent the transpiler defined by ClothesToAccessories (or any other plugin that patches the method) from running.
This version avoids the issue by logging an error instead of throwing an exception.
This version also removes the use of CodeMatcher.SetAndAdvance because it looks like it could destructively modify input code.
Tested with ClothesToAccessories 1.0.3.