Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling feature (workaround fixed) #27

Merged
merged 9 commits into from
Apr 21, 2021
Merged

Scrolling feature (workaround fixed) #27

merged 9 commits into from
Apr 21, 2021

Conversation

jalil49
Copy link
Contributor

@jalil49 jalil49 commented Apr 14, 2021

uncertain how scrolling affects newSlotTransform as the unhooked controls are not removed nor are the correct ones applied

uncertain how scrolling affects newSlotTransform as the unhooked controls are not removed nor are the correct ones applied
@ManlyMarco
Copy link
Collaborator

What's the reason for MakerIntSlider, especially when it still works on a float value? You can do the same with normal slider and custom StringToValue + Mathf.Round on output.

@jalil49
Copy link
Contributor Author

jalil49 commented Apr 18, 2021

Ya it was dumb of me to make a whole new slider, got a weird issue where it defaulted to 23 for some reason, so added some lines of code and added the wholenumber property.

@jalil49 jalil49 changed the title Scrolling feature with workaround Scrolling feature (workaround fixed) Apr 20, 2021
@jalil49
Copy link
Contributor Author

jalil49 commented Apr 20, 2021

left some additional code, feel free to remove it
A. for shit's and giggles
B. potential future debugging

whoops closed by accident

@jalil49 jalil49 closed this Apr 20, 2021
@jalil49 jalil49 reopened this Apr 20, 2021
@jalil49
Copy link
Contributor Author

jalil49 commented Apr 20, 2021

also not sure if the lines of code to fix the 23 default should be allowed to run even when not whole numbers

@ManlyMarco
Copy link
Collaborator

Looks good to me

@ManlyMarco ManlyMarco merged commit 4c49815 into IllusionMods:master Apr 21, 2021
@jalil49
Copy link
Contributor Author

jalil49 commented May 1, 2021

there is an issue, I added a 2nd copy of a line and forgot to remove it at the bottom of adding the scroll, CreateCustomControlsInSubCategory(slotTransform, _accessoryWindowEntries);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants