Upgraded Radiobuttons #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added ability to make rows of toggles Applied Toggle group (sucks i can't just say New ToggleGroup();) Added ability to sync Controlobjects via Unify_AccessoryWindowControl for non-editable controls so the value is displayed Keep toggle on if the same toggle was selected and no others are enabled to prevent confusion
|
|
as per Essu's "This is frustrating, Positively seething" and that it doesn't seem to do anything
|
Things like skirt scale with both/left/right toggles seem to work just fine, so I don't think there conflicts within Koi. |
|
No luck on my end on increasing the size of the radio so I don't have to insert nulls for spaces |
No Idea, why I let this get past me since the result is 23 being everywhere. Can't pinpoint the reason 23 (probably from copied input) occurs here and not in the previous version as No code was deleted and was just moved to a method
|
noticed a side effect of me defaulting the value in sliders, but the bug would remain when the slider is defaulted to 0, since I see 23 on my 0 slider, and the valueonchange doesn't fire. so having it assigned on creation should be good enough to prevent both issues |
Seems like slots are added before scrolling is applied in Classroom maker. So existing controls have to be removed before scrolling is applied
This reverts commit a84bd6a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to make rows of toggles
Applied Toggle group (sucks I can't just say New ToggleGroup();)
Added ability to sync Controlobjects via Unify_AccessoryWindowControl for non-editable controls so the value is displayed
Keep toggle on if the same toggle was selected and no others are enabled to prevent confusion
Current version doesn't retain the value when a new slot is added nor do I think it is possible as is
haven't managed to find a way to increase the height of the control that doesn't scale everything