Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[US][KKS] Fixed a bug that caused an exception when changing clothes #204

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

takahiro0327
Copy link
Collaborator

Fixed a bug that caused an exception when changing clothes. Merge if it looks good.

callstacks:

NullReferenceException: Object reference not set to an instance of an object
  at KK_Plugins.UncensorSelector+UncensorSelectorController.UpdateSkinOverlay () [0x00001] in <1b0e1f94379042399ec02109d7c0bf8a>:0 
  at KK_Plugins.UncensorSelector+UncensorSelectorController+<ReloadCharacterUncensor>d__37.MoveNext () [0x00120] in <1b0e1f94379042399ec02109d7c0bf8a>:0 
  at UnityEngine.SetupCoroutine.InvokeMoveNext (System.Collections.IEnumerator enumerator, System.IntPtr returnValueAddress) [0x00026] in <548b4fa0e7e04f27a1b7580930bfb7dc>:0 

output_log.txt

Reproduction procedure:

  1. launch Sunshine studio
  2. Load any character
  3. Open the Load Costume menu
  4. Click Show Selection
  5. Click on Switch Costumes

スクリーンショット 2023-12-01 190759

It was directly caused by UpdateSkinOverlay() being called while _ksox was null.
Reload is called before Start().
However, this does not seem to happen every time, but only when clicking Show Selection.
There may be a more fundamental cause. Please let me know if there is a problem with the fix.

@ManlyMarco ManlyMarco merged commit c0c47ff into IllusionMods:master Dec 1, 2023
@ManlyMarco
Copy link
Contributor

Thank you for the PR!

This looks to be caused by the plugin that adds the extra switch options, but the fix is general enough to merge into ME.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants