Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more translation suggestions. #104

Merged
merged 17 commits into from
Oct 22, 2022
Merged

Conversation

Vel-Vel
Copy link
Contributor

@Vel-Vel Vel-Vel commented Oct 19, 2022

A few more tweaks to the translation, spelling, and punctuation. Again, feel free to do with them as you please.

Also, I noticed that some of the dialogue lines do not have quotation marks. I have the impression that I have to add the quotation marks back into the dialogue, but I just want to be sure.

@ManlyMarco ManlyMarco merged commit 996610c into IllusionMods:master Oct 22, 2022
@ManlyMarco
Copy link
Collaborator

Thank you for the PR!

Also, I noticed that some of the dialogue lines do not have quotation marks. I have the impression that I have to add the quotation marks back into the dialogue, but I just want to be sure.

Yes, if the original text is in quotes the translated one should be in quotes as well. The OP translation was made a long time ago before this was decided so there may be quite a lot of them missing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants