Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario tweaking and more #109

Merged
merged 737 commits into from
Apr 11, 2023
Merged

Conversation

Vel-Vel
Copy link
Contributor

@Vel-Vel Vel-Vel commented Nov 16, 2022

A few questions (sorry if they are bothersome. I feel like I need a series of guidelines of what to do and what not to do when translating):

When the "っ" is at the end of a Japanese word like "くすくすっ", may it be translated as "--", as in "Kusukusu--"; or may it be dropped, as in "Kusukusu"?

In the parts where the Japanese text is the same (e.g., when the player character wakes up to a girl doing some sexual act on him), should the translation be the same throughout, or may the text have different translations so that it would not be too repetitive? I got this from looking at some of the translations from the Koikatsu Party translation, which does just that.

@ManlyMarco
Copy link
Collaborator

When the "っ" is at the end of a Japanese word like "くすくすっ", may it be translated as "--", as in "Kusukusu--"; or may it be dropped, as in "Kusukusu"?

It can be dropped.

In the parts where the Japanese text is the same (e.g., when the player character wakes up to a girl doing some sexual act on him), should the translation be the same throughout, or may the text have different translations so that it would not be too repetitive? I got this from looking at some of the translations from the Koikatsu Party translation, which does just that.

Ideally the translations would fit the personality, so yes they can be different. Last batch of translations should be merged in soon so all of those that weren't translated yet should be translated soon.

@Vel-Vel Vel-Vel marked this pull request as draft November 18, 2022 22:16
@Vel-Vel Vel-Vel marked this pull request as ready for review November 18, 2022 22:19
@Vel-Vel Vel-Vel closed this Nov 19, 2022
@Vel-Vel Vel-Vel deleted the Scenario-Tweaking branch November 19, 2022 00:42
@Vel-Vel Vel-Vel restored the Scenario-Tweaking branch November 19, 2022 17:08
@Vel-Vel Vel-Vel reopened this Nov 19, 2022
@Vel-Vel Vel-Vel changed the title Scenario tweaking Scenario tweaking and more Nov 19, 2022
@Vel-Vel Vel-Vel mentioned this pull request Nov 19, 2022
Copy link
Collaborator

@ManlyMarco ManlyMarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, but I'm not sure what to do with the zz_machineTranslation edits, I think they should be moved to normal translation files?

@Vel-Vel
Copy link
Contributor Author

Vel-Vel commented Nov 24, 2022

Everything looks good, but I'm not sure what to do with the zz_machineTranslation edits, I think they should be moved to normal translation files?

So this is what we should do after sufficiently cleaning up the machine translation files. Yes. I'll get to it.

@Vel-Vel
Copy link
Contributor Author

Vel-Vel commented Nov 25, 2022

I moved the machine translation files to the normal translation files (not the communication translations yet).

@Vel-Vel Vel-Vel marked this pull request as draft January 5, 2023 08:25
Vel-Vel and others added 2 commits April 11, 2023 10:37
…c06/00/2/translation.txt

Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
…c00/00/2/translation.txt

Co-authored-by: ManlyMarco <39247311+ManlyMarco@users.noreply.github.com>
@Vel-Vel Vel-Vel marked this pull request as ready for review April 11, 2023 18:16
@ManlyMarco ManlyMarco merged commit 3647784 into IllusionMods:master Apr 11, 2023
@Vel-Vel Vel-Vel deleted the Scenario-Tweaking branch April 11, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants