Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow is failing when issue title contains double quotes #122

Open
jainpawan21 opened this issue May 18, 2022 · 2 comments
Open

Workflow is failing when issue title contains double quotes #122

jainpawan21 opened this issue May 18, 2022 · 2 comments

Comments

@jainpawan21
Copy link

jainpawan21 commented May 18, 2022

I tried with single quotes title like This is 'Github' Title, It is working fine. But with This is "Github" Title workflow is failing.

Screenshot:-

Screenshot 2022-05-18 at 11 46 37 PM

@tehhowch
Copy link

tehhowch commented Sep 1, 2022

@jainpawan21 I think the actual issue is that the embed object that was attempted to be sent by that workflow run was invalid JSON. If one opens that failed job and views the workflow file, it is plainly obvious that user-controlled input (i.e. the issue's title) was passed as-is, without any kind of sanitization, to be used in the DISCORD_EMBEDS argument.

Said differently: if you pass in a string that cannot be parsed as valid JSON, what should this action do instead of throwing an error that tells you where your mistake is?

@lltr
Copy link

lltr commented Aug 22, 2023

Facing this issue as well, unable to use ternary in DISCORD_EMBEDS because of this issue as well
${{ steps.step1.outcome == "success" && "pass" || "failed" }}

Sending message ...
Error : 400 Bad Request
Message : { sender: [ 'html_url' ] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants