Redis Sentinel support #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there is no feedback, seems I need to take courage and merge this by myself ;) |
|
Hey @IlyaSkriblovsky, my apologies for not being responsive in a timely manner here. I glanced through the diff and it looks alright. This is much appreciated, you rock. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for service discovery and automatic failover using Redis Sentinel.
Sentinel.master_for()andSentinel.slave_for()create a connection pool that hits Sentinel for an IP address every time it is going to connect to Redis.I am already using it in production for about 5 months and it looks reliable enough on failing over when master node is going down.
Code review would be welcomed!