Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various cleanups and bug fixes #134

Closed

Conversation

arnimarj
Copy link

@arnimarj arnimarj commented Aug 2, 2019

In an effort to fix some lingering issues, we've:

  1. removed code which we aren't using, including the shard/sentinel/unix/monitor/subscriber/watch connection pools.
  2. explicit pipelining and transaction support
  3. removed all but python 3.7 CI support
  4. made hiredis mandatory

Plus, some issues were fixed, including:

  1. The deferred object in RedisFactory was fired when the factory was lazy, resulting in an unhandled deferred on GC events. Easy to test by forcing trial to GC between test runs
  2. Fixed a silly bug in notifying waiters and peekers on Peekable queue, which would result in peekers not being notified on errors
  3. Fixed a silly typo for raiseExcpetion

@arnimarj arnimarj closed this Aug 2, 2019
@arnimarj
Copy link
Author

arnimarj commented Aug 2, 2019

Oops, meant for this to we a PR for my fork

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant