Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to download schema metadata #129

Merged
merged 5 commits into from Apr 26, 2023

Conversation

ImFlog
Copy link
Owner

@ImFlog ImFlog commented Apr 19, 2023

Fixes #122

Add the ability to download schema metadata using a flag.

@ImFlog
Copy link
Owner Author

ImFlog commented Apr 19, 2023

@ferozed, can you tell me if this implementation would work for you ?

@ferozed
Copy link
Contributor

ferozed commented Apr 20, 2023

Looks good. So it will download into the same output folder as normal schema?

Is there a way for me to test this?

@ImFlog
Copy link
Owner Author

ImFlog commented Apr 20, 2023

Yes you can test this, you need to follow the instructions in the readme but a TLDR is to use the publishToMavenLocal task on gradle and than reference the plugin with the mavenLocal in the buildscript repository (like in the examples).

For the other output directory I think we could add the directory in a complex object in the download task extension by I wanted to code something as a POC. I am worried that It could be a problem for json schema (same extension etc).
I can add this capacity next week probably (won't have any more time before the end of the week unfortunately).

@ImFlog
Copy link
Owner Author

ImFlog commented Apr 25, 2023

@ferozed I added the option to specify the metadata directory.
Glad to get feedback on the DSL / usage :)

@ImFlog ImFlog merged commit 72f4cf3 into master Apr 26, 2023
1 check passed
@ImFlog ImFlog deleted the feature/download-metadata branch April 26, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Download and save schema metadata
2 participants