Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema dependency resolution #13

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Add schema dependency resolution #13

merged 3 commits into from
Sep 5, 2018

Conversation

ImFlog
Copy link
Owner

@ImFlog ImFlog commented Aug 31, 2018

Intent to fix #12.

@oasalonen, I spent some time looking for something better than a plain list and thought that a Triple might be better.
Like this we know directly that what we send is the second of the triple and that the rest is here as dependencies. WDYT ?
Anyway this looks a lot like what you did in the first place.

@ImFlog ImFlog mentioned this pull request Sep 3, 2018
@oasalonen
Copy link

Looks good. I would suggest one improvement to the ordering of the dependencies using the user->address->street example. If I understood correctly, right now the syntax would expect you to declare "user.avsc", ["street.avsc", "address.avsc"]. However, the dependency chain would be 'user depends on address depends on street' and as a user I would expect to write them in that order.

So how about you reverse the processing of the dependencies in the list, going from tail to head of the list so user's can write the chain as "user.avsc", ["address.avsc", "street.avsc"]?

@ImFlog
Copy link
Owner Author

ImFlog commented Sep 5, 2018

This is a good idea, I'm doing the changes.

@ImFlog ImFlog merged commit f9b074f into master Sep 5, 2018
@ImFlog ImFlog deleted the schema-dependency branch September 5, 2018 11:56
@ImFlog
Copy link
Owner Author

ImFlog commented Sep 5, 2018

The version 0.4.0 is released and it embed this new feature.

@oasalonen
Copy link

I migrated back to your plugin release and the feature works. Thanks for integrating it!

ImFlog pushed a commit that referenced this pull request Nov 6, 2018
Very similar to #13 this adds the same type of support to
the `testSchemasTask`. Also added metadata for task so it
shows up when `./gradlew tasks` is called.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle dependencies between avsc files for register
2 participants