Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AddressSanitizer: heap-use-after-free at constitute.c:659 #1554

Closed
3 tasks done
hongxuchen opened this issue Apr 27, 2019 · 2 comments
Closed
3 tasks done

AddressSanitizer: heap-use-after-free at constitute.c:659 #1554

hongxuchen opened this issue Apr 27, 2019 · 2 comments

Comments

@hongxuchen
Copy link

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am using the latest version of ImageMagick
  • I have searched open and closed issues to ensure it has not already been reported

Description

ImageMagick convert suffers from a heap-use-after-free vulnerability.

Steps to Reproduce

  • run convert $FILE /dev/null
=================================================================                                                                                                                                                                              
==1962==ERROR: AddressSanitizer: heap-use-after-free on address 0x62700003811c at pc 0x7f2584984c25 bp 0x7ffe24e14170 sp 0x7ffe24e14168                                                                                                        
WRITE of size 4 at 0x62700003811c thread T0                                                                                                                                                                                                    
    #0 0x7f2584984c24 in ReadImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:659:16                                                                                                                               
    #1 0x7f2584987a94 in ReadImages /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:917:9                                                                                                                               
    #2 0x7f2583f5a9a4 in ConvertImageCommand /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/convert.c:644:18                                                                                                                        
    #3 0x7f2584142021 in MagickCommandGenesis /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/mogrify.c:185:14                                                                                                                       
    #4 0x50c8a7 in MagickMain /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:149:10                                                                                                                                         
    #5 0x50c301 in main /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:180:10                                                                                                                                               
    #6 0x7f257cdb3b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310                                                                                                                                          
    #7 0x41ce19 in _start (/home/hongxu/work/imagemagick/ImageMagick-asan/install/bin/magick+0x41ce19)                                                                                                                                         
                                                                                                                                                                                                                                               
0x62700003811c is located 28 bytes inside of 13504-byte region [0x627000038100,0x62700003b5c0)                                                                                                                                                 
freed by thread T0 here:                                                                                                                                                                                                                       
    #0 0x4d22b8 in __interceptor_free.localalias.0 (/home/hongxu/work/imagemagick/ImageMagick-asan/install/bin/magick+0x4d22b8)                                                                                                                
    #1 0x7f2584c5b8d0 in RelinquishMagickMemory /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/memory.c:1074:3                                                                                                                      
    #2 0x7f2584bfa716 in DestroyImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/image.c:1225:19                                                                                                                                
    #3 0x7f25850c3a8a in ReadMATImage /home/hongxu/work/imagemagick/ImageMagick-asan/coders/mat.c:1479:12                                                                                                                                      
    #4 0x7f2584984089 in ReadImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:547:15                                                                                                                               
    #5 0x7f2584987a94 in ReadImages /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:917:9                                                                                                                               
    #6 0x7f2583f5a9a4 in ConvertImageCommand /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/convert.c:644:18                                                                                                                        
    #7 0x7f2584142021 in MagickCommandGenesis /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/mogrify.c:185:14                                                                                                                       
    #8 0x50c8a7 in MagickMain /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:149:10                                                                                                                                         
    #9 0x50c301 in main /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:180:10                                                                                                                                               
    #10 0x7f257cdb3b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310                                                                                                                                         
                                                                                                                                                                                                                                               
previously allocated by thread T0 here:                                                                                                                                                                                                        
    #0 0x4d2470 in __interceptor_malloc (/home/hongxu/work/imagemagick/ImageMagick-asan/install/bin/magick+0x4d2470)                                                                                                                           
    #1 0x7f2584c59fe6 in AcquireMagickMemory /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/memory.c:478:10                                                                                                                         
    #2 0x7f2584bf2d04 in AcquireCriticalMemory /home/hongxu/work/imagemagick/ImageMagick-asan/./MagickCore/memory-private.h:64:10                                                                                                              
    #3 0x7f2584bf075b in AcquireImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/image.c:172:19                                                                                                                                 
    #4 0x7f2584bf572b in AcquireNextImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/image.c:396:15                                                                                                                             
    #5 0x7f25850c2f97 in ReadMATImage /home/hongxu/work/imagemagick/ImageMagick-asan/coders/mat.c:1391:5                                                                                                                                       
    #6 0x7f2584984089 in ReadImage /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:547:15                                                                                                                               
    #7 0x7f2584987a94 in ReadImages /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:917:9                                                                                                                               
    #8 0x7f2583f5a9a4 in ConvertImageCommand /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/convert.c:644:18                                                                                                                        
    #9 0x7f2584142021 in MagickCommandGenesis /home/hongxu/work/imagemagick/ImageMagick-asan/MagickWand/mogrify.c:185:14                                                                                                                       
    #10 0x50c8a7 in MagickMain /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:149:10                                                                                                                                        
    #11 0x50c301 in main /home/hongxu/work/imagemagick/ImageMagick-asan/utilities/magick.c:180:10                                                                                                                                              
    #12 0x7f257cdb3b96 in __libc_start_main /build/glibc-OTsEL5/glibc-2.27/csu/../csu/libc-start.c:310
SUMMARY: AddressSanitizer: heap-use-after-free /home/hongxu/work/imagemagick/ImageMagick-asan/MagickCore/constitute.c:659:16 in ReadImage                                                                                                      
Shadow bytes around the buggy address:                                                                                                                                                                                                         
  0x0c4e7fffefd0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa                                                                                                                                                                              
  0x0c4e7fffefe0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa                                                                                                                                                                              
  0x0c4e7fffeff0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa                                                                                                                                                                              
  0x0c4e7ffff000: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa                                                                                                                                                                              
  0x0c4e7ffff010: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa                                                                                                                                                                              
=>0x0c4e7ffff020: fd fd fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
  0x0c4e7ffff030: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
  0x0c4e7ffff040: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
  0x0c4e7ffff050: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
  0x0c4e7ffff060: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
  0x0c4e7ffff070: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd                                                                                                                                                                              
Shadow byte legend (one shadow byte represents 8 application bytes):                                                                                                                                                                           
  Addressable:           00                                                                                                                                                                                                                    
  Partially addressable: 01 02 03 04 05 06 07                                                                                                                                                                                                  
  Heap left redzone:       fa                                                                                                                                                                                                                  
  Freed heap region:       fd                                                                                                                                                                                                                  
  Stack left redzone:      f1                                                                                                                                                                                                                  
  Stack mid redzone:       f2                                                                                                                                                                                                                  
  Stack right redzone:     f3                                                                                                                                                                                                                  
  Stack after return:      f5                                                                                                                                                                                                                  
  Stack use after scope:   f8                                                                                                                                                                                                                  
  Global redzone:          f9                                                                                                                                                                                                                  
  Global init order:       f6                                                                                                                                                                                                                  
  Poisoned by user:        f7                                                                                                                                                                                                                  
  Container overflow:      fc                                                                                                                                                                                                                  
  Array cookie:            ac                                                                                                                                                                                                                  
  Intra object redzone:    bb                                                                                                                                                                                                                  
  ASan internal:           fe                                                                                                                                                                                                                  
  Left alloca redzone:     ca                                                                                                                                                                                                                  
  Right alloca redzone:    cb                                                                                                                                                                                                                  
==1962==ABORTING
  • POC files are available here.

System Configuration

  • ImageMagick version: 7.0.8-43 Q16 x86_64 2019-04-27 (3183a88)
  • Environment (Operating system, version and so on): Ubuntu 18.04 LTS x86_64
  • Additional information: It reports an assertion failure with regular debug mode compilation.
urban-warrior pushed a commit that referenced this issue Apr 27, 2019
https://github.com/ImageMagick/ImageMagick/issues/1554
f720661
urban-warrior pushed a commit to ImageMagick/ImageMagick6 that referenced this issue Apr 27, 2019
https://github.com/ImageMagick/ImageMagick/issues/1554
5caef6e
@urban-warrior
Copy link
Member

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ https://www.imagemagick.org/download/beta/ by sometime tomorrow.

@nluedtke
Copy link

This was assigned CVE-2019-15140.

lineageos-gerrit pushed a commit to LineageOS/android_external_ImageMagick that referenced this issue Dec 11, 2019
@Huiziyang
https://github.com/ImageMagick/ImageMagick/issues/1554
f7599bb 
Backport of upstream f7206618d27c2e69d977abf40e3035a33e5f6be0

Bug: 140328986

Change-Id: Iaa9773b2efe658948d45f20282f7ed47d8331178
Merged-In: I84d6258cd854be68c752b62964fd746fc6b38fc3
(cherry picked from commit 57879bb058a6c431111e48fa985518ed28efb169)
lineageos-gerrit pushed a commit to LineageOS/android_external_ImageMagick that referenced this issue Dec 22, 2019
@basilgello
https://github.com/ImageMagick/ImageMagick/issues/1554
960d7c3 
Backport of upstream f7206618d27c2e69d977abf40e3035a33e5f6be0

Bug: 140328986

Change-Id: Iaa9773b2efe658948d45f20282f7ed47d8331178
Merged-In: I84d6258cd854be68c752b62964fd746fc6b38fc3
(cherry picked from commit 57879bb058a6c431111e48fa985518ed28efb169)
seluce added a commit to seluce/android_external_ImageMagick that referenced this issue Dec 23, 2019
@seluce
265230 : ImageMagick/ImageMagick#1554
c5be88b
andi34 pushed a commit to android-security/android_external_ImageMagick that referenced this issue Apr 21, 2020
@andi34
https://github.com/ImageMagick/ImageMagick/issues/1554
64bfceb 
Backport of upstream f7206618d27c2e69d977abf40e3035a33e5f6be0

Bug: 140328986

Change-Id: Iaa9773b2efe658948d45f20282f7ed47d8331178
Merged-In: I84d6258cd854be68c752b62964fd746fc6b38fc3
(cherry picked from commit 57879bb058a6c431111e48fa985518ed28efb169)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hongxuchen @urban-warrior @nluedtke