Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory leaks in WritePS3Image #1557

Closed
3 tasks done
butterflyhack opened this issue Apr 28, 2019 · 2 comments
Closed
3 tasks done

memory leaks in WritePS3Image #1557

butterflyhack opened this issue Apr 28, 2019 · 2 comments
Labels
Milestone

Comments

@butterflyhack
Copy link

butterflyhack commented Apr 28, 2019

Prerequisites

  • I have written a descriptive issue title
  • I have verified that I am using the latest version of ImageMagick
  • I have searched open and closed issues to ensure it has not already been reported

Description

==69057==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 13024 byte(s) in 1 object(s) allocated from:
    #0 0x7f7cb84cd602 in malloc (/usr/lib/x86_64-linux-gnu/libasan.so.2+0x98602)
    #1 0x43f2a5 in AcquireMagickMemory MagickCore/memory.c:478
    #2 0x412eef in AcquireCriticalMemory MagickCore/memory-private.h:64
    #3 0x4153a4 in AcquireImageInfo MagickCore/image.c:350
    #4 0x41831c in CloneImageInfo MagickCore/image.c:945
    #5 0x655347 in Huffman2DEncodeImage coders/ps3.c:223
    #6 0x65aa9e in WritePS3Image coders/ps3.c:1343
    #7 0x809a80 in WriteImage MagickCore/constitute.c:1159
    #8 0x80a7a5 in WriteImages MagickCore/constitute.c:1376
    #9 0xb1654b in CompositeImageCommand MagickWand/composite.c:1676
    #10 0xc9fbca in MagickCommandGenesis MagickWand/mogrify.c:185
    #11 0x40e9e1 in MagickMain utilities/magick.c:149
    #12 0x40ebc2 in main utilities/magick.c:180
    #13 0x7f7cb47bd82f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x2082f)

SUMMARY: AddressSanitizer: 13024 byte(s) leaked in 1 allocation(s).

Steps to Reproduce

run cmd;

 /usr/local/bin/magick composite input1 input2 output.ps3

System Configuration

  • ImageMagick version:
    7.0.8-43
  • Environment (Operating system, version and so on):
    Linux ubuntu 4.15.0-47-generic (IM7) Fixed TR/TD placement in MVG docs #50~16.04.1-Ubuntu SMP Fri Mar 15 16:06:21 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
  • Additional information:
    ./configure CC="gcc" CXX="g++" CFLAGS="-g -fsanitize=address" -disable-shared

teatcase:
https://github.com/butterflyhack/pocs/blob/master/memory-leaks-2.zip

credit by ADlab of Venustech

dlemstra added a commit that referenced this issue Apr 28, 2019
dlemstra added a commit to ImageMagick/ImageMagick6 that referenced this issue Apr 28, 2019
@dlemstra
Copy link
Member

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ https://www.imagemagick.org/download/beta/ by sometime tomorrow.

@dlemstra dlemstra added the bug label Apr 28, 2019
@dlemstra dlemstra added this to the 7.0.8-43 milestone Apr 28, 2019
@dlemstra dlemstra closed this as completed May 4, 2019
@abergmann
Copy link

CVE-2019-16712 was assigned to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants