Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.9.4-2 failed test validate-formats-disk.tap #202

Closed
remicollet opened this issue May 18, 2016 · 4 comments
Closed

6.9.4-2 failed test validate-formats-disk.tap #202

remicollet opened this issue May 18, 2016 · 4 comments
Labels

Comments

@remicollet
Copy link
Contributor

* 7.0.1-4 is ok.
* 6.9.4-1 is ok

With latest 6.9.4-2 validate-formats-disk.tap test fails :

$ ./validate -validate formats-disk 
Version: ImageMagick 6.9.4-2 Q16 x86_64 2016-05-18 http://www.imagemagick.org
Copyright: Copyright (C) 1999-2016 ImageMagick Studio LLC

ImageMagick Validation Suite (FormatsDisk)

[pixel-cache: disk] validate image formats in memory:
  test 0: ART/Undefined/TrueColor/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 1: ART/Undefined/TrueColorAlpha/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 2: ART/Undefined/Grayscale/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 3: ART/Undefined/GrayscaleAlpha/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 4: ART/Undefined/Palette/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 5: ART/Undefined/PaletteAlpha/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
  test 6: ART/Undefined/PaletteBilevelAlpha/8-bits... fail @ tests/validate.c/ValidateImageFormatsInMemory/1385.
 ...

Notice, above is output with limit on open files limit raised to 16000, else, with default value=1024 I also got a lot of

lt-validate: UnableToOpenPixelCache `/tmp/magick-28316daAAzKfGEquQ': Too many open files @ error/cache.c/OpenPixelCache/3718.
  test 1115: PS/Undefined/TrueColor/10-bits... fail @ tests/validate.c/ValidateImageFormatsOnDisk/1654.
lt-validate: UnableToOpenPixelCache `/tmp/magick-28316daAAzKfGEquQ': Too many open files @ error/cache.c/OpenPixelCache/3718.
  test 1116: PS/Undefined/TrueColor/12-bits... fail @ tests/validate.c/ValidateImageFormatsOnDisk/1654.
lt-validate: UnableToOpenPixelCache `/tmp/magick-28316daAAzKfGEquQ': Too many open files @ error/cache.c/OpenPixelCache/3718.
  test 1117: PS/Undefined/TrueColor/16-bits... fail @ tests/validate.c/ValidateImageFormatsOnDisk/1654.
lt-validate: UnableToOpenPixelCache `/tmp/magick-28316daAAzKfGEquQ': Too many open files @ error/cache.c/OpenPixelCache/3718.
  summary: 1118 subtests; 18446744073709549568 passed; 2236 failed.
@remicollet
Copy link
Contributor Author

Reproduced on Fedora 20 i386, Fedora 23 x86_64 and RHEL-7

@remicollet
Copy link
Contributor Author

From git bisect, broken by ae79af6

@mikayla-grace
Copy link

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow.

@remicollet
Copy link
Contributor Author

I confirm, bug fixed:

============================================================================
Testsuite summary for ImageMagick 6.9.4
============================================================================
# TOTAL: 76
# PASS:  76
# SKIP:  0
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
============================================================================

@dlemstra dlemstra added the bug label May 18, 2016
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue May 22, 2016
2016-05-18  7.0.1-5 Cristy  <quetzlzacatenango@image...>
  * Release ImageMagick version 7.0.1-5, GIT revision 10789:f7c2e89:20160518,

2016-05-18  7.0.1-5 Cristy  <quetzlzacatenango@image...>
  * Process channels independently for -channel -equalize (reference
    https://www.imagemagick.org/discourse-server/viewtopic.php?f=3&t=29708).
  * Fix pixel cache on disk regression (reference
    ImageMagick/ImageMagick#202).

2016-05-15  7.0.1-4 Cristy  <quetzlzacatenango@image...>
  * Release ImageMagick version 7.0.1-4, GIT revision 10778:52dae14:20160516.

2016-05-10  7.0.1-4 Cristy  <quetzlzacatenango@image...>
  * Quote passwords when passed to a delegate program.
  * Iterate channels over source image rather than destination (bug report
    from Hanno Böck).
  * Can read geo-related EXIF metdata once-again (reference
    ImageMagick/ImageMagick#198).
  * Sanitize all delegate emedded formatting characters.
  * Don't sync pixel cache in AcquireAuthenticCacheView() (bug report from
    Hanno Böck).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants