Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjxl 0.5.0 force disabled when compiling statically despite working pkg-config files #4029

Closed
landfillbaby opened this issue Aug 3, 2021 · 9 comments

Comments

@landfillbaby
Copy link

ImageMagick version

7.1.0-4

Operating system

Linux

Operating system, version and so on

Ubuntu 21.04 x64, Termux aarch64

Description

libjxl v0.5.0, released yesterday, includes working pkg-config files, but magick's configure[.ac] still forces it off

Steps to Reproduce

install libjxl 0.5.0
in imagemagick source,

configure --with-jxl=yes

Images

No response

@landfillbaby landfillbaby changed the title libjxl 0.5.0 force disabled statically despite working pkg-config files libjxl 0.5.0 force disabled when compiling statically despite working pkg-config files Aug 3, 2021
landfillbaby referenced this issue in termux/termux-packages Aug 3, 2021
landfillbaby added a commit to termux/termux-packages that referenced this issue Aug 3, 2021
@dlemstra
Copy link
Member

Thanks for reporting this, we will need to investigate and run some tests with this.

@dlemstra
Copy link
Member

It looks like it is still not working. Feel free to submit a PR that would make this work with a static build.

@landfillbaby
Copy link
Author

landfillbaby commented Aug 17, 2021

this commit fixes the problem! google/brotli@09b0992
i'll open a pr in ImageMagick/brotli

@dlemstra
Copy link
Member

I asked if we can get a new brotli release. And I had to close that PR because we don't need those patches for the Windows build.

@landfillbaby
Copy link
Author

once that next brotli release is out, the next problem with libjxl is #3887

@dlemstra
Copy link
Member

dlemstra commented Aug 17, 2021

I suspect that I already fixed that issue (see my remark in that linked issue).

@dlemstra
Copy link
Member

dlemstra commented Aug 17, 2021

Would you be willing to open an issue here: https://github.com/google/brotli to request the new release? They asked me to do that but I suspect you can explain better why this fixes the static linking. I am not a pkgconfig expert 😁

@landfillbaby
Copy link
Author

oh i forgot to mention, i opened google/brotli#917

@landfillbaby
Copy link
Author

i noticed you allow this with 7.1.0-10 so i'll close it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants