Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

memory exhaustion in ReadPCXImage #536

Closed
bestshow opened this issue Jul 4, 2017 · 2 comments
Closed

memory exhaustion in ReadPCXImage #536

bestshow opened this issue Jul 4, 2017 · 2 comments
Labels

Comments

@bestshow
Copy link

bestshow commented Jul 4, 2017

Version: ImageMagick 7.0.6-1 Q16 x86_64
#./magick identify $FILE
When identify PCX file , imagemagick will allocate memory to store the data.
Here is the critical code:

pixel_info=AcquireVirtualMemory(pcx_packets,2*sizeof(*pixels)); //406

pcx_packets can be controlled as follow:

  pcx_packets=(size_t) image->rows*pcx_info.bytes_per_line; //397
  ...
  pcx_packets=(size_t) pcx_packets*pcx_info.planes; //400

pcx_info.planes can be read from input file

pcx_info.planes=(unsigned char) ReadBlobByte(image); //358

Here is my policy.xml to limit memory usage,but 256MB limit can be bypassed.

...
<policy domain="resource" name="area" value="100MP"/>
<policy domain="resource" name="memory" value="256MiB"/>
...

testcase:https://github.com/bestshow/p0cs/blob/master/memory_exhaustion_in_ReadPCXImage
Creadit : ADLab of Venustech

@mikayla-grace
Copy link

Thanks for the problem report. We can reproduce it and will have a patch to fix it in GIT master branch @ https://github.com/ImageMagick/ImageMagick later today. The patch will be available in the beta releases of ImageMagick @ http://www.imagemagick.org/download/beta/ by sometime tomorrow.

@nohmask
Copy link

nohmask commented Sep 8, 2017

This was assigned CVE-2017-12432.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

4 participants