Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

another approach to fix #5836 #5841

Merged
merged 3 commits into from Dec 2, 2022
Merged

another approach to fix #5836 #5841

merged 3 commits into from Dec 2, 2022

Conversation

multiSnow
Copy link
Contributor

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practices as demonstrated in the repository.

Description

This PR try to fix #5836

  1. add a missing break in switch-case so the JXL_DEC_FULL_IMAGE case would not run twice;
  2. import pixels according to the colorspace value (the IssRGBCompatibleColorspace is not that to detect colorspace is RGB or GRAY).

@urban-warrior urban-warrior merged commit 8a1ac3e into ImageMagick:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unexpexted result of converting from grayscale jxl
2 participants
@multiSnow @urban-warrior