Add JPEG-2000 support to AppImage release (Partially solve #4666) #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 11829a2.
|
The build is failing in the same way the daily is failing, this seems to be unrelated to my change. I'll pull main regularly until it's fixed. |
|
The build issues should be resolved now. |
|
@dlemstra I merged main, everything looks fine now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I added jp2 support to the AppImage, this required only one extra dependency.
I have tested the AppImage build in my own fork, witht hat build I can convert jp2 files to jpeg. For Clang, the resulting AppImage file is about 190 KB larger, which imo is acceptable.