Convert big PDF documents is slow #7263
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion of PDF files When this flag is set the optional ID tag is not generated into PDF
dlemstra
reviewed
Apr 19, 2024
coders/pdf.c
Outdated
| GetImageProperty(image,"signature",exception), | ||
| GetImageProperty(image,"signature",exception)); | ||
| (void) WriteBlobString(image,buffer); | ||
| option=GetImageOption(image_info,"pdf:noID"); |
There was a problem hiding this comment.
pdf:no-identifier would probably be a better name and more consistent with the rest of the names we use.
There was a problem hiding this comment.
OK, I renamed to pdf:no-identifier
coders/pdf.c
Outdated
| (void) WriteBlobString(image,buffer); | ||
| option=GetImageOption(image_info,"pdf:noID"); | ||
| if (IsStringTrue(option) != MagickFalse) { | ||
| (void) DeleteImageProperty(image,"signature"); |
There was a problem hiding this comment.
There is no need to do this call?
There was a problem hiding this comment.
OK, I removed this part.
|
Thanks for merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
I noticed that saving large PDF files with ImageMagick was very slow, and it was generating the PDF ID entry which took a long time.
According to the PDF specification, this ID field is not required (page 47 of Document Management — Portable Document Format — Part 1: PDF 1.7).
So I added the "pdf:noID" option to the PDF encoders which allows this ID field not to be generated.
With a 3 MB JPG file, this goes from 1.12 s to 0.28 s.
Fixes #7262