Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and validate "not applicable" in CSV metadata parsing #507

Open
brianhelba opened this issue Dec 8, 2017 · 1 comment
Open

Support and validate "not applicable" in CSV metadata parsing #507

brianhelba opened this issue Dec 8, 2017 · 1 comment

Comments

@brianhelba
Copy link
Member

The value "not applicable" should be accepted by the metadata parser, and should ultimately result in a null value being emitted as the field value.

However, as a guard against mistakes from the metadata contributor, the inter-field validation step should also ensure that values marked "not applicable" are truly not applicable in the given metadata context (and not accidentally used in places where "unknown" would be semantically more appropriate).

This will likely require the implementation to temporarily differentiate between "unknown"/"" values and "not applicable" values, while still saving both as None in the "load" step.

@msmolens
Copy link
Contributor

As a first step, a simple change would be to accept "not applicable" everywhere that "unknown" is currently accepted. Beyond that, it would be useful to first list some specific validation rules for "not applicable" vs. "unknown".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants