Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ThreadPool as context manager #54

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Use ThreadPool as context manager #54

merged 1 commit into from
Jul 13, 2023

Conversation

zachmullen
Copy link
Collaborator

Fixes #53.

These ThreadPools require closure to prevent undefined behavior.

From the docs:

their resources must also be properly managed, either by using the pool as a context manager or by calling close() and terminate() manually.

@zachmullen
Use ThreadPool as context manager
2344a15 
Fixes #53.

These ThreadPools require closure to prevent undefined behavior.
@danlamanna
Copy link
Member

First paragraph of the docs huh.. 😅.

@danlamanna danlamanna merged commit 7af8138 into master Jul 13, 2023
6 checks passed
@danlamanna danlamanna deleted the threadpool-teardown branch July 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlamanna danlamanna Awaiting requested review from danlamanna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix cross-platform SIGINT issues
2 participants
@zachmullen @danlamanna