Skip to content

Commit

Permalink
Improve error response from pydantic validator
Browse files Browse the repository at this point in the history
This should go away when vitalik/django-ninja#825 is resolved.
  • Loading branch information
zachmullen committed Aug 17, 2023
1 parent c23afb1 commit ce32a05
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions isic/core/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
from django.shortcuts import get_object_or_404
from isic_metadata import FIELD_REGISTRY
from ninja import Schema
from ninja.errors import ValidationError
from pydantic import validator
from pydantic_core import PydanticCustomError
from pyparsing.exceptions import ParseException
from rest_framework import serializers
from rest_framework.fields import Field
Expand Down Expand Up @@ -103,7 +103,7 @@ def valid_search_query(cls, value: str):
except ParseException:
# TODO normally we should raise a ValueError, but django-ninja 1.0a2 has a bug
# https://github.com/vitalik/django-ninja/issues/825
raise ValidationError(["Couldn't parse search query."])
raise PydanticCustomError("invalid_query", "Couldn't parse search query.")
return value

@validator("collections", pre=True)
Expand Down

0 comments on commit ce32a05

Please sign in to comment.