Allow single-part response for retrieve instance

[hackermd]

Some origin servers respond to retrieve instance requests with a message containing only a single part. While this is not compliant with the standard, the client should be able to handle this behavior. It will log an error message to make users aware of the standard compliance issue.

[hackermd]

@pieper @ntenenz what are your thoughts regarding the Accept header? One the one hand, I think we should now include application/dicom in the list of acceptable media types to prevent a server from responding with a 406 error code although we would actually accept the content type. On the other hand, I am concerned that this may break things with some servers. We had issues with origin servers in the past that did not correctly implement HTTP.

[pieper]

Here I'd side on sticking to the standard and not offer to accept a non-standard type. If the user defined Accept in the headers param would it override the client code or vise versa?

[hackermd]

Here I'd side on sticking to the standard and not offer to accept a non-standard type.

That was my initial thought, too.

If the user defined Accept in the headers param would it override the client code or vise versa?

Good question. I haven't thought about the possibility of someone setting the Accept header for the entire session. It looks like headers passed via the request method will override the headers that have been set on the session object (see requests.sessions.merge_settings()).

[hackermd]

@pieper @ntenenz can we complete this PR?

[ntenenz]

LGTM

[pieper]

👍

[hackermd]

@pieper @ntenenz Great! Thanks for your feedback. Could one of you kindly approve the PR? Then I will merge the changes, draft a new release and publish a new version on pypi.

[pieper]

Odd, I thought I approved yesterday but I must not have clicked the right button...

[pieper]

It happened again - I clicked "Add your review" and selected "Approve" but that did not clear the "Review required" flag. I guess I don't have write access here.

[ntenenz]

Steve and I are both showing as have approved the PR. I agree, it looks like neither of us have write access.