Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get_remaining parameter to search methods #60

Merged
merged 1 commit into from Feb 14, 2022

Conversation

hackermd
Copy link
Collaborator

@hackermd hackermd commented Jan 12, 2022

An origin server may limit the number of results that are included in the payload of the response message. The remaining results can then be retrieved via additional requests using the offset parameter. Getting all results is possible with the currently API, but cumbersome. This PR adds a get_remaining parameter to search methods that facilitates retrieval of all search results.

@hackermd hackermd added the enhancement New feature or request label Jan 12, 2022
@hackermd hackermd self-assigned this Jan 12, 2022
@hackermd hackermd requested a review from cgorman January 12, 2022 21:45
Copy link
Member

@cgorman cgorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Been dogfooding this for the past month, lgtm!

@hackermd hackermd merged commit 83254a7 into master Feb 14, 2022
@hackermd hackermd deleted the feature/iteratively-search-remaining branch February 14, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants