Skip to content

Commit

Permalink
Remove some unnecessary additions
Browse files Browse the repository at this point in the history
  • Loading branch information
CPBridge committed Apr 11, 2024
1 parent f84f074 commit 62dcbe6
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 18 deletions.
7 changes: 0 additions & 7 deletions src/highdicom/ann/sop.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,13 +233,6 @@ def __init__(
'Annotation Group Number {i + 1} instead of '
f'{group.AnnotationGroupNumber}.'
)
if coordinate_type == AnnotationCoordinateTypeValues.SCOORD:
# This is a little ugly, but because the constructor of the
# AnnotationGroup class does not know the coordinate type, it
# always adds the CommonZCoordinateValue. However this should
# not be resent for 2D coordinates. So we will remove it here.
if hasattr(group, 'CommonZCoordinateValue'):
delattr(group, 'CommonZCoordinateValue')
self.AnnotationGroupSequence.append(group)

def get_annotation_group(
Expand Down
11 changes: 0 additions & 11 deletions tests/test_ann.py
Original file line number Diff line number Diff line change
Expand Up @@ -651,17 +651,6 @@ def test_construction(self, annotation_coordinate_type):
assert first_group_has_common_z
assert second_group_has_common_z

wrong_coordinate_type = (
'3D' if annotation_coordinate_type.value == 'SCOORD'
else '2D'
)
# with pytest.raises(ValueError):
# d = second_retrieved_group.get_graphic_data(
# coordinate_type=wrong_coordinate_type
# )
# print(len(d))
# print(len(d[0].shape))

retrieved_groups = annotations.get_annotation_groups(
graphic_type=GraphicTypeValues.POINT
)
Expand Down

0 comments on commit 62dcbe6

Please sign in to comment.