Implementation of Softcopy Presentation States #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can't seem to add @seandoyle as a reviewer(?) but would be great if he could take a look also! |
We will need to add him to the team. However, he should still be able to just a review. |
|
Nice @CPBridge! Looks great at first glance. I will take a closer look and review. It would be great if we could add support for the LUTs of the grayscale transformation:
|
|
Sure, I'll add in the LUT parts |
…ighdicom into feature/presentation_state
hackermd
reviewed
Apr 27, 2022
…alette_color_lut Few changes related to presentation state
…alette_color_lut Fix bugs in advanced blending
This was referenced May 14, 2022
Merged
Remove 8 bit LUTs
|
@hackermd so are we good to go on this now? |
…dality-lut Fix assumptions about tiled images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of GSPS. Focus is on text and graphic annotations, other optional functionality such as shutters, masks, crops, and transformations is omitted, but could be added later.
Tested in Osirix viewer.