Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctests #165

Merged
merged 12 commits into from
Apr 2, 2022
Merged

Doctests #165

merged 12 commits into from
Apr 2, 2022

Conversation

CPBridge
Copy link
Collaborator

@CPBridge CPBridge commented Apr 2, 2022

Unfortunately #143 has grown stale because changes were required that the contributor (working on their own fork) has not made. Furthermore, there are now conflicts with master.

In order to get these changes in while keeping the contributor's commits in the library for recognition of the contributions, I have taken the commits from the fork and started this new pull request where I have made the changes myself.

Additionally I am updating the github workflows to run doctests automatically.

Partially addresses #126 by testing snippets in docstrings, but does not test the examples in the rst files in such as usage.rst. which are arguably more important. We will probably need a different approach there.

@CPBridge CPBridge added the documentation Improvements or additions to documentation label Apr 2, 2022
@CPBridge CPBridge requested a review from hackermd April 2, 2022 18:31
@CPBridge CPBridge marked this pull request as ready for review April 2, 2022 18:31
Copy link
Collaborator

@hackermd hackermd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @CPBridge

@hackermd hackermd merged commit b9a6a3e into master Apr 2, 2022
@hackermd hackermd deleted the doctest branch April 2, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants