Allow duplicate entries in ReferencedSeriesSequence #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackermd
approved these changes
Jun 22, 2023
src/highdicom/seg/sop.py
Outdated
| unique_instance_data = list(dict.fromkeys(instance_data)) | ||
| if len(unique_instance_data) != len(instance_data): | ||
| logger.warning( | ||
| 'Duplicate entries found in the ReferencedSeriesSequence.' |
There was a problem hiding this comment.
This log message could benefit from a few additional details, such as the SOP Instance UID of the instance and potentially also the duplicate entries. That information may help developers to debug the issue.
There was a problem hiding this comment.
Addressed in 311d2f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have come across some segmentations where there are duplicate entries in the ReferencedSeriesSequence. Highdicom just crashes with an unhelpful message in this situation. It doesn't really make sense to have duplicate entries here, but it's not explicitly disallowed, so in this PR I deduplicate them and allow them through, and log a warning.