Exclude incompatible pydicom 2.4.0 in setup.py #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that the issue is now fixed in pydicom and pydicom versions >= 2.4.1 should again be compatible with highdicom. So it's just this one version short-lived (2.4.0) that we need to exclude from highdicom's dependencies. |
hackermd
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydicom 2.4.0 is essentially incompatible with highdicom, see #233 and pydicom/pydicom#1813
The fix introduced in https://github.com/pydicom/pydicom/pulls/1814 and was released in pydicom 2.4.1. We should therefore exclude the specific problematic version of pydicom (2.4.0) in our setup.py.