Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert plane positions to plane position slide sequence #240

Conversation

thomas-albrecht
Copy link
Contributor

Here is a new branch to fix #231

@CPBridge
Copy link
Collaborator

Thanks!

(For future reference, it may have been easier to simply git rebase and git push -f (force push) on your existing pull request.)

@CPBridge CPBridge added the bug Something isn't working label Jun 21, 2023
@CPBridge CPBridge self-assigned this Jun 21, 2023
@thomas-albrecht
Copy link
Contributor Author

Thanks for the tip. I typically always just merge and never rebase.
But that makes a lot of sense. I would have needed the -f because rebase messes with the history somehow.

@CPBridge CPBridge merged commit 723f579 into ImagingDataCommons:master Jun 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

get_plane_positions_of_image returns list of pydicom.Sequence instead of highdicom.PlanePositionSequence
3 participants