Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use list comprehension where possible #262

Merged

Conversation

DimitriPapadopoulos
Copy link
Contributor

No description provided.

Copy link
Collaborator

@CPBridge CPBridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 of these 3 changes could break user code and should be reverted

src/highdicom/seg/sop.py Outdated Show resolved Hide resolved
src/highdicom/seg/sop.py Outdated Show resolved Hide resolved
The order of the returned list should not be modified.
@CPBridge CPBridge merged commit 4a25af4 into ImagingDataCommons:master Oct 11, 2023
11 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the list_comprehension branch October 11, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants