Integrate new pydicom DS formatting #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This replaces #57 |
hackermd
approved these changes
Apr 8, 2021
|
Thanks @CPBridge. We'll have to wait with merging until pydicom 2.2 will be released. |
|
Merged into dev branch to integrate into #93 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #57, highdicom currently produces datasets with invalid decimal strings in many situations. The functionality to correctly format DSs is now integrated into pydicom, see pydicom/pydicom#1334.
This PR integrates this behaviour into highdicom wherever it sets a value for a DS attribute.
Important this depends upon behaviour on pydicom master branch that will be in the next release of pydicom, which will be 2.2.0. I have updated
setup.pyto reflect this. This PR should not be merged until such a time that pydicom 2.2.0 is released and available on pypi. Tests will also fail until that time, but they do pass on my local machine when I have pydicom installed from master branch.